Hi Geert, kernel test robot noticed the following build errors: [auto build test ERROR on next-20231016] url: https://github.com/intel-lab-lkp/linux/commits/Geert-Uytterhoeven/sunrpc-Use-no_printk-in-dfprintk-dummies/20231017-104813 base: next-20231016 patch link: https://lore.kernel.org/r/a93de2e8afa826745746b00fc5f64e513df5d52f.1697104757.git.geert%2Brenesas%40glider.be patch subject: [PATCH -next v2] sunrpc: Use no_printk() in dfprintk*() dummies config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20231020/202310200734.I6x6UCe1-lkp@xxxxxxxxx/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231020/202310200734.I6x6UCe1-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202310200734.I6x6UCe1-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): In file included from include/linux/kernel.h:31, from arch/x86/include/asm/percpu.h:27, from arch/x86/include/asm/current.h:10, from include/linux/sched.h:12, from include/linux/sunrpc/svcauth_gss.h:12, from fs/nfsd/nfsfh.c:13: fs/nfsd/nfsfh.c: In function 'nfsd_setuser_and_check_port': >> fs/nfsd/nfsfh.c:111:47: error: 'buf' undeclared (first use in this function) 111 | svc_print_addr(rqstp, buf, sizeof(buf))); | ^~~ include/linux/printk.h:427:33: note: in definition of macro 'printk_index_wrap' 427 | _p_func(_fmt, ##__VA_ARGS__); \ | ^~~~~~~~~~~ include/linux/printk.h:129:17: note: in expansion of macro 'printk' 129 | printk(fmt, ##__VA_ARGS__); \ | ^~~~~~ include/linux/sunrpc/debug.h:70:41: note: in expansion of macro 'no_printk' 70 | # define dfprintk(fac, fmt, ...) no_printk(fmt, ##__VA_ARGS__) | ^~~~~~~~~ include/linux/sunrpc/debug.h:25:9: note: in expansion of macro 'dfprintk' 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__) | ^~~~~~~~ fs/nfsd/nfsfh.c:110:17: note: in expansion of macro 'dprintk' 110 | dprintk("nfsd: request from insecure port %s!\n", | ^~~~~~~ fs/nfsd/nfsfh.c:111:47: note: each undeclared identifier is reported only once for each function it appears in 111 | svc_print_addr(rqstp, buf, sizeof(buf))); | ^~~ include/linux/printk.h:427:33: note: in definition of macro 'printk_index_wrap' 427 | _p_func(_fmt, ##__VA_ARGS__); \ | ^~~~~~~~~~~ include/linux/printk.h:129:17: note: in expansion of macro 'printk' 129 | printk(fmt, ##__VA_ARGS__); \ | ^~~~~~ include/linux/sunrpc/debug.h:70:41: note: in expansion of macro 'no_printk' 70 | # define dfprintk(fac, fmt, ...) no_printk(fmt, ##__VA_ARGS__) | ^~~~~~~~~ include/linux/sunrpc/debug.h:25:9: note: in expansion of macro 'dfprintk' 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__) | ^~~~~~~~ fs/nfsd/nfsfh.c:110:17: note: in expansion of macro 'dprintk' 110 | dprintk("nfsd: request from insecure port %s!\n", | ^~~~~~~ vim +/buf +111 fs/nfsd/nfsfh.c 9d7ed1355db5b0 J. Bruce Fields 2018-03-08 101 6fa02839bf9412 J. Bruce Fields 2007-11-12 102 static __be32 nfsd_setuser_and_check_port(struct svc_rqst *rqstp, 6fa02839bf9412 J. Bruce Fields 2007-11-12 103 struct svc_export *exp) 6fa02839bf9412 J. Bruce Fields 2007-11-12 104 { 12045a6ee9908b J. Bruce Fields 2009-12-08 105 int flags = nfsexp_flags(rqstp, exp); 12045a6ee9908b J. Bruce Fields 2009-12-08 106 6fa02839bf9412 J. Bruce Fields 2007-11-12 107 /* Check if the request originated from a secure port. */ 9d7ed1355db5b0 J. Bruce Fields 2018-03-08 108 if (!nfsd_originating_port_ok(rqstp, flags)) { 5216a8e70e25b0 Pavel Emelyanov 2008-02-21 109 RPC_IFDEBUG(char buf[RPC_MAX_ADDRBUFLEN]); a48fd0f9f77b6e Kinglong Mee 2014-05-29 110 dprintk("nfsd: request from insecure port %s!\n", 6fa02839bf9412 J. Bruce Fields 2007-11-12 @111 svc_print_addr(rqstp, buf, sizeof(buf))); 6fa02839bf9412 J. Bruce Fields 2007-11-12 112 return nfserr_perm; 6fa02839bf9412 J. Bruce Fields 2007-11-12 113 } 6fa02839bf9412 J. Bruce Fields 2007-11-12 114 6fa02839bf9412 J. Bruce Fields 2007-11-12 115 /* Set user creds for this exportpoint */ 6fa02839bf9412 J. Bruce Fields 2007-11-12 116 return nfserrno(nfsd_setuser(rqstp, exp)); 6fa02839bf9412 J. Bruce Fields 2007-11-12 117 } 6fa02839bf9412 J. Bruce Fields 2007-11-12 118 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
