> > > > On Oct 4, 2023, at 6:14 AM, Lorenzo Bianconi <lorenzo.bianconi@xxxxxxxxxx> wrote: > > > >> On Mon, 11 Sep 2023 14:49:46 +0200 Lorenzo Bianconi wrote: > >>> + hdr = genlmsg_put(skb, NETLINK_CB(cb->skb).portid, cb->nlh->nlmsg_seq, > >>> + &nfsd_server_nl_family, NLM_F_MULTI, > >>> + NFSD_CMD_RPC_STATUS_GET); > >>> + if (!hdr) > >>> + return -ENOBUFS; > >> > >> Why NLM_F_MULTI? AFAIU that means "I'm splitting one object over > >> multiple messages". 99% of the time the right thing to do is change > >> what we consider to be "an object" rather than do F_MULTI. In theory > >> user space should re-constitute all the NLM_F_MULTI messages into as > >> single object, which none of YNL does today :( > >> > > ack, fine. I think we can get rid of it. > > @chuck: do you want me to send a patch or are you taking care of it? > > Send a (tested) patch and I can squash it into this one. ack, I will do. Regards, Lorenzo > > > -- > Chuck Lever > >
Attachment:
signature.asc
Description: PGP signature
