Hi Jakub- > On Oct 3, 2023, at 1:55 PM, Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > > On Mon, 11 Sep 2023 14:49:44 +0200 Lorenzo Bianconi wrote: >> Introduce nfsd_server.yaml specs to generate uAPI and netlink >> code for nfsd server. >> Add rpc-status specs to define message reported by the nfsd server >> dumping the pending RPC requests. > > Sorry for the delay, some minor "take it or leave it" nits below. > >> +doc: >> + nfsd server configuration over generic netlink. >> + >> +attribute-sets: >> + - >> + name: rpc-status-comp-op-attr >> + enum-name: nfsd-rpc-status-comp-attr >> + name-prefix: nfsd-attr-rpc-status-comp- >> + attributes: >> + - >> + name: unspec >> + type: unused >> + value: 0 > > the unused attrs can usually be skipped, the specs now start with value > of 1 by default. Same for the unused command. > >> + - >> + name: dport >> + type: u16 >> + byte-order: big-endian >> + - >> + name: compond-op >> + type: array-nest > > Avoid array-nests if you can, they are legacy (does this spec pass JSON > schema validation?). > > There's only one attribute in the nest, can you use > > - > name: op > type: u32 > multi-attr: true > > ? I've made similar modifications to Lorenzo's original contribution. The current updated version of this spec is here: https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git/commit/?h=nfsd-next&id=55f55c77f624066895470306898190f090e00cda >> + nested-attributes: rpc-status-comp-op-attr > >> + - >> + name: rpc-status-get >> + doc: dump pending nfsd rpc >> + attribute-set: rpc-status-attr >> + dump: >> + pre: nfsd-server-nl-rpc-status-get-start >> + post: nfsd-server-nl-rpc-status-get-done > > No attributes listed? User space C codegen will need those to make > sense of the commands. -- Chuck Lever
