On Fri, 2023-09-29 at 09:58 -0400, Chuck Lever wrote: > Tidy up the server-side XDR encoders for NFSv4 OPEN and LOCK > results. Series applies to nfsd-next. See topic branch > "nfsd4-encoder-overhaul" in this repo: > > https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git > > --- > > Chuck Lever (7): > NFSD: Add nfsd4_encode_lock_owner4() > NFSD: Refactor nfsd4_encode_lock_denied() > NFSD: Add nfsd4_encode_open_read_delegation4() > NFSD: Add nfsd4_encode_open_write_delegation4() > NFSD: Add nfsd4_encode_open_none_delegation4() > NFSD: Add nfsd4_encode_open_delegation4() > NFSD: Clean up nfsd4_encode_open() > > > fs/nfsd/nfs4state.c | 6 +- > fs/nfsd/nfs4xdr.c | 305 +++++++++++++++++++++++++++----------------- > fs/nfsd/xdr4.h | 2 +- > 3 files changed, 189 insertions(+), 124 deletions(-) > > -- > Chuck Lever > Looks pretty straightforward. I had one minor nit about the struct packing but the rest looks fine. You can add: Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>