On Tue, 2023-09-26 at 09:04 +1000, NeilBrown wrote: > > Are writes blocked while the delegation returns proceeds? If not, > would > it be reasonable to start a separate kthread on-demand when a return > is > requested? > That's what we've done historically. We initially made it be the same thread as the standard recovery thread because we do want to serialise recovery and delegation return. However the recovery thread has the ability to block all other RPC to the server in question, so that requirement that we serialise does not depend on the two threads being the same. In practice, therefore, we usually ended up with multiple separate threads when reboot recovery was required during a delegation return, or if a single sweep of the delegations took too long. -- Trond Myklebust Linux NFS client maintainer, Hammerspace trond.myklebust@xxxxxxxxxxxxxxx
