[PATCH fstests v2 3/3] generic/187: don't run this test on NFS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This test is unreliable on NFS. It fails consistently when run vs. a
server exporting btrfs, but passes when the server exports xfs. Since we
don't have any sort of attribute that we can require to test this, just
skip this one on NFS.

Also, subsume the check for btrfs into the _supported_fs check, and add
a comment for it.

Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
---
 tests/generic/187 | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tests/generic/187 b/tests/generic/187
index 0653b92f12f4..1b3509424462 100755
--- a/tests/generic/187
+++ b/tests/generic/187
@@ -29,13 +29,17 @@ _cleanup()
 . ./common/reflink
 
 # real QA test starts here
+
+# btrfs can't fragment free space. This test is unreliable on NFS, as it
+# depends on the exported filesystem.
+_supported_fs ^btrfs ^nfs generic
 _require_scratch_reflink
 _require_cp_reflink
 _require_xfs_io_command "falloc"
 _require_xfs_io_command "fpunch"
-test $FSTYP = "btrfs" && _notrun "Can't fragment free space on btrfs."
 _require_odirect
 
+
 _fragment_freesp()
 {
 	file=$1

-- 
2.41.0




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux