On Thu, 17 Aug 2023 at 16:55, Chuck Lever III <chuck.lever@xxxxxxxxxx> wrote: > > On Aug 17, 2023, at 10:49 AM, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > > > > I'm sure it's right, but it really smells odd to set that initial > > offset not when the bvec is created, but long afterwards, just before > > it is used. > > > > Is there some reason why 'bv_offset' isn't initialized when the bvec is created? > > Yes: > > https://lore.kernel.org/linux-nfs/7c9421cc4b92dee76cc7560c50a4a0ab3fb1ef0d.camel@xxxxxxxxxx/T/#t Ugh, how ugly. > But also note that this fix will get replaced in v6.6 > > I just wanted to ensure that v6.5 wasn't broken. It's a little late in the > cycle to apply 383bc8bbc. Sounds good to me. Thanks for the explanation. Linus
