On Wed, 2023-08-16 at 20:48 -0500, Jordan Rife wrote: > [You don't often get email from jrife@xxxxxxxxxx. Learn why this is > important at https://aka.ms/LearnAboutSenderIdentification ;] > > kernel_connect() will modify the rpc_xprt socket address in contexts > where eBPF programs perform NAT instead of iptables. In these > contexts, > it is common for an NFS mount to be mounted to be a static virtual IP > while the server has an ephemeral IP leading to a problem where the > virtual IP gets overwritten and forgotten. When the endpoint IP > changes, > reconnect attempts fail and the mount never recovers. > > This patch protects addr from being modified in these scenarios, > allowing > NFS reconnects to work as intended. What? No! A connect() call should not be allowed to modify its own call parameters. -- Trond Myklebust Linux NFS client maintainer, Hammerspace trond.myklebust@xxxxxxxxxxxxxxx
