On Tue, 2023-08-08 at 10:21 +0200, Lorenzo Bianconi wrote:
> Introduce version field to nfsd_rpc_status handler in order to help
> the user to maintain backward compatibility.
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
> ---
> fs/nfsd/nfssvc.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
> index 33ad91dd3a2d..6d5feeeb09a7 100644
> --- a/fs/nfsd/nfssvc.c
> +++ b/fs/nfsd/nfssvc.c
> @@ -1117,6 +1117,9 @@ int nfsd_stats_release(struct inode *inode, struct file *file)
> return ret;
> }
>
> +/* Increment NFSD_RPC_STATUS_VERSION adding new info to the handler */
> +#define NFSD_RPC_STATUS_VERSION 1
> +
> static int nfsd_rpc_status_show(struct seq_file *m, void *v)
> {
> struct inode *inode = file_inode(m->file);
> @@ -1125,6 +1128,8 @@ static int nfsd_rpc_status_show(struct seq_file *m, void *v)
>
> rcu_read_lock();
>
> + seq_printf(m, "# version %u\n", NFSD_RPC_STATUS_VERSION);
> +
> for (i = 0; i < nn->nfsd_serv->sv_nrpools; i++) {
> struct svc_rqst *rqstp;
>
Should we also add a line that starts with '#' to show what the fields
indicate? Either way, this is fine:
Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>
