On Mon, 31 Jul 2023, NeilBrown wrote: > On Mon, 31 Jul 2023, Chuck Lever wrote: > > On Tue, Jul 18, 2023 at 09:37:58AM -0400, Chuck Lever wrote: > > > On Tue, Jul 18, 2023 at 04:38:08PM +1000, NeilBrown wrote: > > > > When a sequence of numbers are needed for internal-use only, an enum is > > > > typically best. The sequence will inevitably need to be changed one > > > > day, and having an enum means the developer doesn't need to think about > > > > renumbering after insertion or deletion. The patch will be easier to > > > > review. > > > > > > Last sentence needs to define the antecedant of "The patch". > > > > I've changed the last sentence in the description to "Such patches > > will be easier ..." > > > > I've applied 1/5 through 5/5, with a few cosmetic changes, to the > > SUNRPC threads topic branch. 6/6 needed more work: > > Ah - ok. I was all set to resubmit with various changes and > re-ordering. I guess I waited too long. > > > All this will appear in the nfsd repo later today. > > Not yet.... No, they are there - the top date looked rather old so I thought there was nothing new yet. Sorry. NeilBrown
