On 25 Jul 2023, at 7:59, Fedor Pchelkin wrote: > Another highly rare error case when a page allocating loop (inside > __nfs4_get_acl_uncached, this time) is not properly unwound on error. > Since pages array is allocated being uninitialized, need to free only > lower array indices. NULL checks were useful before commit 62a1573fcf84 > ("NFSv4 fix acl retrieval over krb5i/krb5p mounts") when the array had > been initialized to zero on stack. > > Found by Linux Verification Center (linuxtesting.org). > > Fixes: 62a1573fcf84 ("NFSv4 fix acl retrieval over krb5i/krb5p mounts") > Signed-off-by: Fedor Pchelkin <pchelkin@xxxxxxxxx> Nice one. Reviewed-by: Benjamin Coddington <bcodding@xxxxxxxxxx>