Re: [PATCH RFC 0/4] Send RPC-on-TCP with one sock_sendmsg() call

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2023-07-09 at 16:04 -0400, Chuck Lever wrote:
> After some discussion with David Howells at LSF/MM 2023, we arrived
> at a plan to use a single sock_sendmsg() call for transmitting an
> RPC message on socket-based transports. This is an initial part of
> the transition to support handling folios with file content, but it
> has scalability benefits as well.
> 
> Comments, suggestions, and test results are welcome.
> 
> ---
> 
> Chuck Lever (4):
>       SUNRPC: Convert svc_tcp_sendmsg to use bio_vecs directly
>       SUNRPC: Convert svc_udp_sendto() to use the per-socket bio_vec array
>       SUNRPC: Use a per-transport receive bio_vec array
>       SUNRPC: Send RPC message on TCP with a single sock_sendmsg() call
> 
> 
>  include/linux/sunrpc/svc.h     |   1 -
>  include/linux/sunrpc/svcsock.h |   7 ++
>  net/sunrpc/svcsock.c           | 142 ++++++++++++++++++---------------
>  3 files changed, 86 insertions(+), 64 deletions(-)
> 
> --
> Chuck Lever
> 

Aside from my concerns with bounds checking on the first patch, this
looks like a good set of changes overall. Does it show any performance
improvements in your testing?
-- 
Jeff Layton <jlayton@xxxxxxxxxx>




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux