On Thu 25-05-23 07:46:22, Dan Carpenter wrote: > On Wed, May 24, 2023 at 04:06:48PM +0200, Jan Kara wrote: > > Yes, I've checked and all ->encode_fh() implementations return > > FILEID_INVALID in case of problems (which are basically always only > > problems with not enough space in the handle buffer). > > ceph_encode_fh() can return -EINVAL > > $ smdb.py functions encode_fh > where > $ for i in $(cut -d '|' -f 3 where | sort -u) ; do smdb.py return_states $i ; done | grep INTER | tee out Ah, I've missed that return hidden in ceph_encode_snapfh(). This is indeed cool use of static analysis ;) Thanks for noticing! Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
