> > --- > > Note to reviewers: the one case where this patch would modify existing behavior > > is when strlen(src)==destlen==0. Current behavior returns 0, with this patch it > > would return -1. > > > > Not sure what the implication of this updated behavior would be, > > so bringing it to your attention. > > I'm not sure either, but I would prefer non-terminated strings produce > an error, which this change does. :) > > Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx> > Friendly ping.