> On May 13, 2023, at 10:44 PM, Azeem Shaikh <azeemshaikh38@xxxxxxxxx> wrote: > >>> No, I plan to land this patch before attempting to fix __assign_str itself. >>> Let me know if the below description looks good to you and I'll send >>> over a v3 patch: >>> >>> [PATCH v3] NFSD: Remove open coding of string copy >>> >>> Instead of open coding a __dynamic_array(), use the __string() and >>> __assign_str() >>> helper macros that exist for this kind of use case. >>> >>> Part of an effort to remove deprecated strlcpy() [1] completely from the >>> kernel[2]. >>> >>> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy >>> [2] https://github.com/KSPP/linux/issues/89 >>> >>> Fixes: 3c92fba557c6 ("NFSD: Enhance the nfsd_cb_setup tracepoint") >>> Signed-off-by: Azeem Shaikh <azeemshaikh38@xxxxxxxxx> >> >> This looks good to me. So you'd like me to take this through >> the nfsd tree, possibly for 6.4-rc ? >> > > This is my first week contributing to the Linux kernel so I might be > miscommunicating :) > By "land this patch", I meant to get this patch into to the nfsd tree. > I'll leave it up to you when you push it through to the mainline tree. > Although, it would be great to get this through to 6.4-rc if that's at > all possible. Please send v3 along, and I will apply it to nfsd-fixes. -- Chuck Lever
