On 21 Apr 2023, at 14:27, Anna Schumaker wrote: > From: Anna Schumaker <Anna.Schumaker@xxxxxxxxxx> > > And add some basic checking so we only enable features that are present > in a given NFS version. > > Signed-off-by: Anna Schumaker <Anna.Schumaker@xxxxxxxxxx> > --- This is great, I like how you've kept the +/- notation similar to knfsd supported versions. Another way to do this would be an attribute file per capability, setting it to 0 or 1 which is more inline with sysfs usage. I think if we do use this, we ought to leave readdir plus out of it because there's already a mount option for it. Readdir plus can be turned on and off with a remount already. The issue for me would be how to work out what the behavior should be when we have a mount that has "nordirplus" and then someone tries to toggle it via sysfs. Any other thoughts? I'll add this patch to my future postings of sysfs work. Ben
