Re: Did the in-kernel Camellia or CMAC crypto implementation break?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Chuck Lever III <chuck.lever@xxxxxxxxxx> wrote:

> Ah, I see Scott is Cc'd. Yes, Scott reported this to me yesterday.

Found it (see patch sent separately).  There was an uninitialised variable in
sunrpc.

The krb5lib problem was that I'd lost the byteswapping of the usage value in
the test data when I split it out of the net/rxrpc/ directory, e.g.:

@@ -167,7 +167,7 @@ const struct krb5_enc_test krb5_enc_tests[] = {
 		.plain	= "'1",
 		.conf	= "6F2FC3C2A166FD8898967A83DE9596D9",
 		.K0	= "5027BC231D0F3A9D23333F1CA6FDBE7C",
-		.usage	= 1,
+		.usage	= htonl(1),
 		.ct	= "842D21FD950311C0DD464A3F4BE8D6DA88A56D559C9B47D3F9A85067AF661559B8",
 	}, {
 		.krb5	= &krb5_camellia128_cts_cmac,

David




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux