On Sat, 2023-04-01 at 13:22 -0700, Dai Ngo wrote: > Currently callback request does not use the credential specified in > CREATE_SESSION if the security flavor for the back channel is AUTH_SYS. > > Problem was discovered by pynfs 4.1 DELEG5 and DELEG7 test with error: > DELEG5 st_delegation.testCBSecParms : FAILURE > expected callback with uid, gid == 17, 19, got 0, 0 > > Signed-off-by: Dai Ngo <dai.ngo@xxxxxxxxxx> > --- > fs/nfsd/nfs4callback.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c > index 2a815f5a52c4..4039ffcf90ba 100644 > --- a/fs/nfsd/nfs4callback.c > +++ b/fs/nfsd/nfs4callback.c > @@ -946,8 +946,8 @@ static const struct cred *get_backchannel_cred(struct nfs4_client *clp, struct r > if (!kcred) > return NULL; > > - kcred->uid = ses->se_cb_sec.uid; > - kcred->gid = ses->se_cb_sec.gid; > + kcred->fsuid = ses->se_cb_sec.uid; > + kcred->fsgid = ses->se_cb_sec.gid; > return kcred; > } > } Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>
