Re: [PATCH 1/2] nfsd: don't replace page in rq_pages if it's a continuation of last page

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2023-03-17 at 15:04 +0000, Chuck Lever III wrote:
> 
> > On Mar 17, 2023, at 10:59 AM, Jeff Layton <jlayton@xxxxxxxxxx> wrote:
> > 
> > On Fri, 2023-03-17 at 14:16 +0000, Chuck Lever III wrote:
> > 
> > > In the patch description, would you mention that this case
> > > arises if the READ request is not page-aligned?
> > 
> > Does it though? I'm not sure that page alignment has that much to do
> > with it. I imagine you can hit this even with aligned I/Os.
> 
> Maybe, but no-one has actually seen that. The vast majority of
> reports of this problem are with unaligned I/O, which POSIX OS
> NFS clients (like the Linux NFS client) usually avoid.
> 
> I didn't mean to exclude the possibility of hitting this issue
> in other ways, but simply observing a common way it is hit.
> 

An unaligned read will consume an extra page, so maybe it just makes it
more likely to overrun the array in that case?
-- 
Jeff Layton <jlayton@xxxxxxxxxx>




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux