Hi Christian, I love your patch! Yet something to improve: [auto build test ERROR on eeac8ede17557680855031c6f305ece2378af326] url: https://github.com/intel-lab-lkp/linux/commits/Christian-Brauner/nfs-use-vfs-setgid-helper/20230313-212725 base: eeac8ede17557680855031c6f305ece2378af326 patch link: https://lore.kernel.org/r/20230313-fs-nfs-setgid-v1-1-5b1fa599f186%40kernel.org patch subject: [PATCH] nfs: use vfs setgid helper config: parisc64-defconfig (https://download.01.org/0day-ci/archive/20230314/202303140652.dN7XrtM4-lkp@xxxxxxxxx/config) compiler: hppa64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/503d040be490a519b2e483672702dcca530443ce git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Christian-Brauner/nfs-use-vfs-setgid-helper/20230313-212725 git checkout 503d040be490a519b2e483672702dcca530443ce # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=parisc64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=parisc64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303140652.dN7XrtM4-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>, old ones prefixed by <<): >> ERROR: modpost: "setattr_should_drop_sgid" [fs/nfs/nfs.ko] undefined! -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
