----- Original Message -----
> From: "Calum Mackay" <calum.mackay@xxxxxxxxxx>
> To: "Tigran Mkrtchyan" <tigran.mkrtchyan@xxxxxxx>, "J. Bruce Fields" <bfields@xxxxxxxxxxxx>
> Cc: "Calum Mackay" <calum.mackay@xxxxxxxxxx>, "Jeff Layton" <jlayton@xxxxxxxxxx>, "Dai Ngo" <dai.ngo@xxxxxxxxxx>,
> "linux-nfs" <linux-nfs@xxxxxxxxxxxxxxx>, "Frank Filz" <ffilzlnx@xxxxxxxxxxxxxx>
> Sent: Saturday, 25 February, 2023 16:57:12
> Subject: Re: [pynfs RFC PATCH] nfs4.0/testserver.py: don't return an error when tests fail
> On 25/02/2023 11:45 am, Mkrtchyan, Tigran wrote:
>>
>> ----- Original Message -----
>>> From: "J. Bruce Fields" <bfields@xxxxxxxxxxxx>
>>> To: "Jeff Layton" <jlayton@xxxxxxxxxx>
>>> Cc: "Dai Ngo" <dai.ngo@xxxxxxxxxx>, "linux-nfs" <linux-nfs@xxxxxxxxxxxxxxx>,
>>> "Frank Filz" <ffilzlnx@xxxxxxxxxxxxxx>
>>> Sent: Thursday, 23 February, 2023 16:11:32
>>> Subject: Re: [pynfs RFC PATCH] nfs4.0/testserver.py: don't return an error when
>>> tests fail
>>
>>> I orginally thought I'd continue maintaining pynfs on a volunteer basis,
>>> but I haven't been. These all look like reasonable changes, but someone
>>> else probably needs to step in to make sure they're handled in a
>>> reasonable amount of time.
>>>
>>
>> Well, I already have a fork in github that is used by others. Thus I can try to
>> pick the patches from the mailing list and try to keep the tree up-to-date.
>
> hi Tigran, I was going to take it over from Bruce, unless you'd prefer
> to, which is fine?
Hi Calum,
just go ahead!
Thanks for the effort,
Tigran.
>
> cheers,
> calum.
>
>>
>> Tigran.
>>> --b.
>>>
>>> On Wed, Feb 22, 2023 at 08:49:52AM -0500, Jeff Layton wrote:
>>>> This script was originally changed in eb3ba0b60055 ("Have testserver.py
>>>> have non-zero exit code if any tests fail"), but the same change wasn't
>>>> made to the 4.1 testserver.py script.
>>>>
>>>> There also wasn't much explanation for it, and it makes it difficult to
>>>> tell whether the test harness itself failed, or whether there was a
>>>> failure in a requested test.
>>>>
>>>> Stop the 4.0 testserver.py from exiting with an error code when a test
>>>> fails, so that a successful return means only that the test harness
>>>> itself worked, not that every requested test passed.
>>>>
>>>> Cc: Frank Filz <ffilzlnx@xxxxxxxxxxxxxx>
>>>> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
>>>> ---
>>>> nfs4.0/testserver.py | 2 --
>>>> 1 file changed, 2 deletions(-)
>>>>
>>>> I'm not sure about this one. I've worked around this in kdevops for now,
>>>> but it would really be preferable if it worked this way, imo. If this
>>>> isn't acceptable, maybe we can add a new option that enables this
>>>> behavior?
>>>>
>>>> Frank, what was the original rationale for eb3ba0b60055 ?
>>>>
>>>> diff --git a/nfs4.0/testserver.py b/nfs4.0/testserver.py
>>>> index f2c41568e5c7..4f4286daa657 100755
>>>> --- a/nfs4.0/testserver.py
>>>> +++ b/nfs4.0/testserver.py
>>>> @@ -387,8 +387,6 @@ def main():
>>>>
>>>> if nfail < 0:
>>>> sys.exit(3)
>>>> - if nfail > 0:
>>>> - sys.exit(2)
>>>>
>>>> if __name__ == "__main__":
>>>> main()
>>>> --
>>>> 2.39.2
>
> --
> Calum Mackay
> Linux Kernel Engineering
> Oracle Linux and Virtualisation
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
