On 23 Nov 2022, at 5:08, Anders Blomdell wrote: > Our problems turned out to be a fallout of Al Viros's splice rework, where nfsd reads with non-zero offsets and not ending > on a page boundary failed to remap the last page. I belive that this is a decent fix for that problem (tested on v6.1-rc6, > 6.0.7 and 6.0.9) > > ---- a/fs/nfsd/vfs.c > +++ b/fs/nfsd/vfs.c > @@ -873,7 +873,7 @@ nfsd_splice_actor(struct pipe_inode_info *pipe, struct pipe_buffer *buf, > unsigned offset = buf->offset; > page += offset / PAGE_SIZE; > - for (int i = sd->len; i > 0; i -= PAGE_SIZE) > + for (int i = sd->len + offset % PAGE_SIZE; i > 0; i -= PAGE_SIZE) > svc_rqst_replace_page(rqstp, page++); > if (rqstp->rq_res.page_len == 0) // first call > rqstp->rq_res.page_base = offset % PAGE_SIZE; Does anyone have insight into how we could possibly have caught this in testing? I have been unable to make my knfsd hit this problem: it returns unaligned READs all day long, no problems. Ben
