On Mon, Nov 14, 2022 at 10:16:12AM -0500, Chuck Lever wrote: > Steven Rostedt says: > > The include/trace/events/ directory should only hold files that > > are to create events, not headers that hold helper functions. > > > > Can you please move them out of include/trace/events/ as that > > directory is "special" in the creation of events. > > Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx> > --- > drivers/infiniband/core/cm_trace.h | 2 > drivers/infiniband/core/cma_trace.h | 2 > fs/nfs/nfs4trace.h | 6 - > fs/nfs/nfstrace.h | 6 - > include/trace/events/fs.h | 122 ----------- > include/trace/events/nfs.h | 375 ----------------------------------- > include/trace/events/rdma.h | 168 ---------------- > include/trace/events/rpcgss.h | 2 > include/trace/events/rpcrdma.h | 4 > include/trace/events/sunrpc.h | 2 > include/trace/events/sunrpc_base.h | 18 -- > include/trace/misc/fs.h | 122 +++++++++++ > include/trace/misc/nfs.h | 375 +++++++++++++++++++++++++++++++++++ > include/trace/misc/rdma.h | 168 ++++++++++++++++ > include/trace/misc/sunrpc.h | 18 ++ > 15 files changed, 695 insertions(+), 695 deletions(-) > delete mode 100644 include/trace/events/fs.h > delete mode 100644 include/trace/events/nfs.h > delete mode 100644 include/trace/events/rdma.h > delete mode 100644 include/trace/events/sunrpc_base.h > create mode 100644 include/trace/misc/fs.h > create mode 100644 include/trace/misc/nfs.h > create mode 100644 include/trace/misc/rdma.h > create mode 100644 include/trace/misc/sunrpc.h > > Note: with an Acked-by from both the NFS client and RDMA core > maintainers I can take this through the nfsd for-next tree, unless > someone has another suggestion. Please update MAINTAINERS file too. diff --git a/MAINTAINERS b/MAINTAINERS index 4db8e4e02c05..86e57325eb6e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10054,6 +10054,7 @@ F: drivers/infiniband/ F: include/rdma/ F: include/trace/events/ib_mad.h F: include/trace/events/ib_umad.h +F: include/trace/misc/rdma.h F: include/uapi/linux/if_infiniband.h F: include/uapi/rdma/ F: samples/bpf/ibumad_kern.c Thanks, Acked-by: Leon Romanovsky <leonro@xxxxxxxxxx>
