> On Nov 12, 2022, at 7:27 AM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > Hi Chuck, > > I was just looking over some files in include/trace/events/ and noticed > that there's sunrpc_base.h, fs.h and nfs.h that are not event files. > > The include/trace/events/ directory should only hold files that are to > create events, not headers that hold helper functions. > > Can you please move them out of include/trace/events/ as that directory > is "special" in the creation of events. > > Perhaps we could create a new directory include/linux/trace/ or > include/trace/linux/ specific for these types of files? I can take responsibility for moving the helper files I created. IIRC there are a few from the RDMA core subsystem as well. But let's first decide on a proper destination for such files. A sister directory to include/trace/events, like include/trace/ < something > makes sense to me. -- Chuck Lever
