On Sat, 12 Nov 2022 07:27:42 -0500 Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > Hi Chuck, > > I was just looking over some files in include/trace/events/ and noticed > that there's sunrpc_base.h, fs.h and nfs.h that are not event files. > > The include/trace/events/ directory should only hold files that are to > create events, not headers that hold helper functions. > > Can you please move them out of include/trace/events/ as that directory > is "special" in the creation of events. > > Perhaps we could create a new directory include/linux/trace/ or > include/trace/linux/ specific for these types of files? > Hi Vlastimil, I also noticed that mmflags.h is in that directory too. I'd like to keep only headers defining TRACE_EVENT() in that directory, as files there have special meaning. Thanks, -- Steve