Hi Dave, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v6.0-rc3] [also build test WARNING on linus/master next-20220830] [cannot apply to trondmy-nfs/linux-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Dave-Wysochanski/Convert-NFS-with-fscache-to-the-netfs-API/20220831-085217 base: b90cb1053190353cc30f0fef0ef1f378ccc063c5 config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20220831/202208311054.eXBCcm1y-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/5ac59d0573d1008c9d8856a91e4b4fd2ee61bb63 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Dave-Wysochanski/Convert-NFS-with-fscache-to-the-netfs-API/20220831-085217 git checkout 5ac59d0573d1008c9d8856a91e4b4fd2ee61bb63 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash fs/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): fs/nfs/fscache.c: In function 'nfs_netfs_read_initiate': >> fs/nfs/fscache.c:331:42: warning: variable 'sreq' set but not used [-Wunused-but-set-variable] 331 | struct netfs_io_subrequest *sreq; | ^~~~ fs/nfs/fscache.c: In function 'nfs_netfs_read_done': fs/nfs/fscache.c:346:42: warning: variable 'sreq' set but not used [-Wunused-but-set-variable] 346 | struct netfs_io_subrequest *sreq; | ^~~~ vim +/sreq +331 fs/nfs/fscache.c 327 328 void nfs_netfs_read_initiate(struct nfs_pgio_header *hdr) 329 { 330 struct nfs_netfs_io_data *netfs = hdr->netfs; > 331 struct netfs_io_subrequest *sreq; 332 333 if (!netfs) 334 return; 335 336 sreq = netfs->sreq; 337 spin_lock(&netfs->lock); 338 atomic_inc(&netfs->rpcs); 339 netfs->rpc_byte_count += hdr->args.count; 340 spin_unlock(&netfs->lock); 341 } 342 -- 0-DAY CI Kernel Test Service https://01.org/lkp
