On 8/30/2022 1:49 AM, David Howells wrote: > Casey Schaufler <casey@xxxxxxxxxxxxxxxx> wrote: > >> The authors of this version of the mount code failed to look >> especially closely at how Smack maintains label names. Once a >> label name is used in the kernel it is kept on a list forever. >> All the copies of smk_known here and in the rest of the mount >> infrastructure are unnecessary and wasteful. The entire set of >> Smack hooks that deal with mounting need to be reworked to remove >> that waste. It's on my list of Smack cleanups, but I'd be happy >> if someone else wanted a go at it. > I don't have time to overhaul Smack right now. Should I drop the Smack part > of the patch? No. I appreciate that you're including Smack as part of the effort. I would much rather have the code working as you have it than have to go in later and do it all from scratch. With luck I should be able to get someone with a considerably lower level of expertise to work on it. > David
