On Wed, 2022-08-24 at 09:00 -0400, David Wysochanski wrote: > On Wed, Aug 24, 2022 at 8:42 AM Trond Myklebust > <trondmy@xxxxxxxxxxxxxxx> wrote: > > > > On Wed, 2022-08-24 at 05:35 -0400, Dave Wysochanski wrote: > > > As first steps for support of the netfs library, add > > > NETFS_SUPPORT > > > to Kconfig and add the required netfs_inode into struct > > > nfs_inode. > > > The struct netfs_inode is now where the vfs_inode is stored as > > > well > > > as the fscache_cookie. In addition, use the netfs_inode() and > > > netfs_i_cookie() helpers, and remove our own helper, > > > nfs_i_fscache(). > > > > > > Later patches will enable netfs by defining NFS specific version > > > of struct netfs_request_ops and calling netfs_inode_init(). > > > > > > Signed-off-by: Dave Wysochanski <dwysocha@xxxxxxxxxx> > > > --- > > > fs/nfs/Kconfig | 1 + > > > fs/nfs/delegation.c | 2 +- > > > fs/nfs/dir.c | 2 +- > > > fs/nfs/fscache.c | 20 +++++++++----------- > > > fs/nfs/fscache.h | 15 ++++++--------- > > > fs/nfs/inode.c | 6 +++--- > > > fs/nfs/internal.h | 2 +- > > > fs/nfs/pnfs.c | 12 ++++++------ > > > fs/nfs/write.c | 2 +- > > > include/linux/nfs_fs.h | 19 +++++-------------- > > > 10 files changed, 34 insertions(+), 47 deletions(-) > > > > > > diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig > > > index 14a72224b657..79b241bed762 100644 > > > --- a/fs/nfs/Kconfig > > > +++ b/fs/nfs/Kconfig > > > @@ -5,6 +5,7 @@ config NFS_FS > > > select LOCKD > > > select SUNRPC > > > select NFS_ACL_SUPPORT if NFS_V3_ACL > > > + select NETFS_SUPPORT > > > > > > > NACK. I'm not at all OK with making netfs mandatory. > > > > Just so we're on the same page, are you ok with netfs being enabled > if > fscache is enabled like today? > As long as it is an opt-in feature, I'm OK. I don't want to have to compile it in by default. A cachefs should never become a mandatory feature of networked filesystems. -- Trond Myklebust Linux NFS client maintainer, Hammerspace trond.myklebust@xxxxxxxxxxxxxxx
