"NeilBrown": > Thanks for the report. > This possibility of calling d_delete() twice has been present > since 9019fb391de0 in v5.16. I don't think 9019fb391de0 is a problem. Before v6.0-rc1, the target dentry was unhashed by __d_drop() call in nfs_unlink(), and nfs_dentry_handle_enoent() skipped calling d_delete() by simple_positive(). d_delete() was called only once via nfs_dentry_remove_handle_error(). In v6.0-rc1, the dentry is not unhashed and nfs_dentry_handle_enoent() doesn't skip calling d_delete(). > How did you discover this bug, and why do you think my patch > caused it? I met this problem during a stress test aiming a filesystem I am developing. And I think unhashing causes nfs_dentry_handle_enoent() to call d_delete(). J. R. Okajima
