> On Aug 4, 2022, at 2:14 PM, J. Bruce Fields <bfields@xxxxxxxxxxxx> wrote: > > On Thu, Aug 04, 2022 at 03:43:56PM +0000, Chuck Lever III wrote: >> It passes, but leaves the test file so that clean_dir does not work >> again until the old lease expires. > > Oh, right. > >>> But possibly cleanup should also be better. >> >> This bug might prevent running these tests in an automation harness. >> I'd say cleanup does need to be better about this. >> >>> I'm not sure what the right fix is. >> >> Brute force: keep trying to delete that file if clean_dir receives >> NFS4ERR_DELAY? > > Delegations block unlinks too so that probably doesn't help. Just keep trying until the lease expires. But that's a naive approach. >> init_connection somewhere needs to set up a callback service and >> leave it running. > > The callback isn't too important, I think, if we want to return the > delegation at the end of the test we can do that without waiting for the > server to remind us. That would help a lot, I think, and would not require an active callback service on the client. Btw, DELEG5 has the same problem... and btw, it's final OPEN fails with EACCES... I'm looking into that too. > Or maybe destroy the client at the end. We have no DESTROY_CLIENTID > (this is 4.0), but we could do a client-rebooting SETCLIENTID/CONFIRM to > wipe out its state. -- Chuck Lever
