Re: [PATCH v2 5/9] tst_test.sh: Add $TST_ALL_FILESYSTEMS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi all,

I wonder if we want to sort filesystems:

-for _tst_fs in $(tst_supported_fs); do
+for _tst_fs in $(tst_supported_fs | sort); do

or even -u (as uniq).

Martin used it in testcases/misc/lvm/prepare_lvm.sh, but IMHO it should not be
needed: looping over fs_type_whitelist() should be always the same.

FS_LIST=`tst_supported_fs | sort -u`

Therefore I'd remove it (don't use unnecessary dependencies - be nice for people
with minimal environment):

Kind regards,
Petr



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux