On Fri, 2022-07-08 at 14:24 -0400, Chuck Lever wrote:
> There has always been the capability of exporting filecache metrics
> via /proc, but it was never hooked up. Let's surface these metrics
> to enable better observability of the filecache.
>
> Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
> ---
> fs/nfsd/nfsctl.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index 66c352bf61b1..ecc08cf97a86 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -25,6 +25,7 @@
> #include "state.h"
> #include "netns.h"
> #include "pnfs.h"
> +#include "filecache.h"
>
> /*
> * We have a single directory with several nodes in it.
> @@ -46,6 +47,7 @@ enum {
> NFSD_MaxBlkSize,
> NFSD_MaxConnections,
> NFSD_SupportedEnctypes,
> + NFSD_Filecache,
> /*
> * The below MUST come last. Otherwise we leave a hole in nfsd_files[]
> * with !CONFIG_NFSD_V4 and simple_fill_super() goes oops
> @@ -229,6 +231,13 @@ static const struct file_operations reply_cache_stats_operations = {
> .release = single_release,
> };
>
> +static const struct file_operations filecache_ops = {
> + .open = nfsd_file_cache_stats_open,
> + .read = seq_read,
> + .llseek = seq_lseek,
> + .release = single_release,
> +};
> +
> /*----------------------------------------------------------------------------*/
> /*
> * payload - write methods
> @@ -1370,6 +1379,7 @@ static int nfsd_fill_super(struct super_block *sb, struct fs_context *fc)
> [NFSD_Ports] = {"portlist", &transaction_ops, S_IWUSR|S_IRUGO},
> [NFSD_MaxBlkSize] = {"max_block_size", &transaction_ops, S_IWUSR|S_IRUGO},
> [NFSD_MaxConnections] = {"max_connections", &transaction_ops, S_IWUSR|S_IRUGO},
> + [NFSD_Filecache] = {"filecache", &filecache_ops, S_IRUGO},
> #if defined(CONFIG_SUNRPC_GSS) || defined(CONFIG_SUNRPC_GSS_MODULE)
> [NFSD_SupportedEnctypes] = {"supported_krb5_enctypes", &supported_enctypes_ops, S_IRUGO},
> #endif /* CONFIG_SUNRPC_GSS or CONFIG_SUNRPC_GSS_MODULE */
>
>
<facepalm>
Ouch, that's quite an oversight.
</facepalm>
--
Jeff Layton <jlayton@xxxxxxxxxx>
