On Mon, 2022-06-06 at 10:50 -0400, Chuck Lever wrote: > A bad verifier is not a garbage argument, it's an authentication > failure. Retrying it doesn't make the problem go away, and delays > upper layer recovery steps. > > Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx> > --- > net/sunrpc/clnt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c > index e2c6eca0271b..ed13d55df720 100644 > --- a/net/sunrpc/clnt.c > +++ b/net/sunrpc/clnt.c > @@ -2649,7 +2649,7 @@ rpc_decode_header(struct rpc_task *task, struct xdr_stream *xdr) > > out_verifier: > trace_rpc_bad_verifier(task); > - goto out_garbage; > + goto out_err; > > out_msg_denied: > error = -EACCES; > > Looks like this will mostly manifest as an -EIO return, which is what we want in most cases for a munged verifer. Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>
