I tried the change suggested by the comment, and things broke. IMO that demonstrates the necessity of leaving the fh_verify() call in place. Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx> --- fs/nfsd/filecache.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c index 23c51b95d2a2..ae813e6f645f 100644 --- a/fs/nfsd/filecache.c +++ b/fs/nfsd/filecache.c @@ -992,7 +992,6 @@ nfsd_do_file_acquire(struct svc_rqst *rqstp, struct svc_fh *fhp, unsigned int hashval; bool retry = true; - /* FIXME: skip this if fh_dentry is already set? */ status = fh_verify(rqstp, fhp, S_IFREG, may_flags|NFSD_MAY_OWNER_OVERRIDE); if (status != nfs_ok)
