On Mon, 06 Jun 2022, Chuck Lever wrote: > While looking into the filecache CPU soft lock-up issue, I ran > across this problem. I thought I could run it down in just an > afternoon (I was wrong) and that this problem probably affects more > users than the soft lock-up (jury's still out). > > Anyway, NFSD's new READDIRPLUS dirent encoder blows past the end of > the directory payload xdr_stream when the client requests more than > a page worth of directory entries. I tracked this down to how > xdr_get_next_encode_buffer() computes xdr->end. First patch in this > series is the fix. The remaining patches are clean-ups and > optimizations. > > I want to get this into 5.19-rc quickly. I would appreciate getting > at least two R-b's for this series. Just for completeness: Reviewed-by: NeilBrown <neilb@xxxxxxx> for the whole series. Nothing I saw would justify any delay. NeilBrown > > --- > > Chuck Lever (5): > SUNRPC: Fix the calculation of xdr->end in xdr_get_next_encode_buffer() > SUNRPC: Optimize xdr_reserve_space() > SUNRPC: Clean up xdr_commit_encode() > SUNRPC: Clean up xdr_get_next_encode_buffer() > SUNRPC: Remove pointer type casts from xdr_get_next_encode_buffer() > > > net/sunrpc/xdr.c | 31 ++++++++++++++++++++++--------- > 1 file changed, 22 insertions(+), 9 deletions(-) > > -- > Chuck Lever > >
