Thanks for the link. I think that goto is really useful and makes a lot of sense when there are different parts in the function where you want to go to the exit block. I think this function is not one of those cases since there's only one exit point and the goto can be easily removed, in my case 3rd try :) Maybe at some point, this function had different parts in the code where it went to the "out" block. But not anymore. However, I don´t have a strong opinion on this patch. If it's accepted that's great but mostly I wanted to learn the process of how to contribute to the kernel and I did it! Thanks, Javier On Fri, 20 May 2022 at 14:41, Benjamin Coddington <bcodding@xxxxxxxxxx> wrote: > > On 20 May 2022, at 8:00, Javier Abrego Lorente wrote: > > > final version, I promise. > > Javier, please read "7) Centralized exiting of functions" in > Documentation/process/coding-style.rst. The maintainers are unlikely to > take this patch because it doesn't (my opinion) improve the readability, and > removing a goto isn't a valid reason on its own. The use of goto is an > acceptable practice in the linux kernel for some patterns. > > Ben >
