From: Anna Schumaker <Anna.Schumaker@xxxxxxxxxx>
Previously, decoding was a one step process that expanded holes as they
were seen in the buffer. This had a few undesireable side effects:
1) An extra READ_PLUS call was often needed to fetch any data shifted
off the end of the buffer when the last two segments are a HOLE
followed by DATA
2) We shifted the entire remaining buffer for each hole, meaning some
segments would get moved multiple times during one decode pass.
These patches attempt to address this by turning READ_PLUS decoding into
a two-step process. First, we build up a list of each segment returned
by the server, then we walk the list in reverse and move each segment
directly to their target offset. This cuts out all the extra copying,
and means we won't lose any data off of the end of the reply.
The results of my performance testing can be found here:
https://wiki.linux-nfs.org/wiki/index.php/Read_Plus_May_2022
Between these patches and the corresponding server patches, I'm seeing a
several second decrease in the amount of time that a READ_PLUS call
takes to complete even on the worst case test where pages alternate
between hole and data segments.
I also optimistically remove the CONFIG_NFS_V4_2_READ_PLUS Kconfig
option now that the known performance and correctness issues have been
resolved, but I would also be fine with changing it to default to 'y' if
there are objections to entirely dropping the option.
Please note that these patches rely on the xdr_stream_move_segment()
function added as the first patch of the corresponding server patches.
Thoughts?
Anna
Anna Schumaker (5):
SUNRPC: Add a function for directly setting the xdr page len
SUNRPC: Add a function for zeroing out a portion of an xdr_stream
NFS: Replace the READ_PLUS decoding code
SUNRPC: Remove xdr_align_data() and xdr_expand_hole()
NFS: Remove the CONFIG_NFS_V4_2_READ_PLUS Kconfig option
fs/nfs/Kconfig | 9 --
fs/nfs/nfs42xdr.c | 168 +++++++++++++++++++------------------
fs/nfs/nfs4proc.c | 2 +-
include/linux/sunrpc/xdr.h | 5 +-
net/sunrpc/xdr.c | 111 +++++++++++-------------
5 files changed, 140 insertions(+), 155 deletions(-)
--
2.36.1
