----- Ursprüngliche Mail ----- > Von: "chuck lever" <chuck.lever@xxxxxxxxxx> > An: "Steve Dickson" <steved@xxxxxxxxxx> > CC: "richard" <richard@xxxxxx>, "linux-nfs" <linux-nfs@xxxxxxxxxxxxxxx>, "david" <david@xxxxxxxxxxxxx>, "bfields" > <bfields@xxxxxxxxxxxx>, "luis turcitu" <luis.turcitu@xxxxxxxxxxxxxx>, "david young" <david.young@xxxxxxxxxxxxxx>, > "david oberhollenzer" <david.oberhollenzer@xxxxxxxxxxxxx>, "trond myklebust" <trond.myklebust@xxxxxxxxxxxxxxx>, "anna > schumaker" <anna.schumaker@xxxxxxxxxx>, "chris chilvers" <chris.chilvers@xxxxxxxxxxxxxx> > Gesendet: Dienstag, 10. Mai 2022 15:48:49 > Betreff: Re: [PATCH 1/5] Implement reexport helper library >> On May 10, 2022, at 9:32 AM, Steve Dickson <steved@xxxxxxxxxx> wrote: >> >> Hello, >> >> On 5/2/22 4:50 AM, Richard Weinberger wrote: >>> This internal library contains code that will be used by various >>> tools within the nfs-utils package to deal better with NFS re-export, >>> especially cross mounts. >>> Signed-off-by: Richard Weinberger <richard@xxxxxx> >>> --- >>> configure.ac | 12 ++ >>> support/Makefile.am | 4 + >>> support/reexport/Makefile.am | 6 + >>> support/reexport/reexport.c | 285 +++++++++++++++++++++++++++++++++++ >>> support/reexport/reexport.h | 39 +++++ >>> 5 files changed, 346 insertions(+) >>> create mode 100644 support/reexport/Makefile.am >>> create mode 100644 support/reexport/reexport.c >>> create mode 100644 support/reexport/reexport.h >>> diff --git a/configure.ac b/configure.ac >>> index 93626d62..86bf8ba9 100644 >>> --- a/configure.ac >>> +++ b/configure.ac >>> @@ -274,6 +274,17 @@ AC_ARG_ENABLE(nfsv4server, >>> fi >>> AM_CONDITIONAL(CONFIG_NFSV4SERVER, [test "$enable_nfsv4server" = "yes" ]) >>> +AC_ARG_ENABLE(reexport, >>> + [AC_HELP_STRING([--enable-reexport], >>> + [enable support for re-exporting NFS mounts @<:@default=no@:>@])], >>> + enable_reexport=$enableval, >>> + enable_reexport="no") >>> + if test "$enable_reexport" = yes; then >>> + AC_DEFINE(HAVE_REEXPORT_SUPPORT, 1, >>> + [Define this if you want NFS re-export support >>> compiled in]) >>> + fi >>> + AM_CONDITIONAL(CONFIG_REEXPORT, [test "$enable_reexport" = "yes" ]) >>> + >> To get this moving I'm going to add a --disable-reexport flag > > Hi Steve, no-one has given a reason why disabling support > for re-exports would be necessary. Therefore, can't this > switch just be removed? Sure can we remove it. My idea was that new/experimental features should be opt-in. Thanks, //richard
