On Thu, Apr 07, 2022 at 10:09:04AM +0300, Max Gurtovoy wrote:
>
> On 4/7/2022 12:54 AM, Jason Gunthorpe wrote:
> > On Thu, Apr 07, 2022 at 12:01:44AM +0300, Max Gurtovoy wrote:
> >
> > > > @@ -267,59 +258,53 @@ enum ib_device_cap_flags {
> > > > * stag.
> > > > */
> > > > IB_DEVICE_MEM_MGT_EXTENSIONS = IB_UVERBS_DEVICE_MEM_MGT_EXTENSIONS,
> > > MEM_MGT_EXTENSIONS is used also in the kernel ULPs (storage)
> > It is not about where it is used, it is about if it is part of the
> > uapi or not. Cleanly separating uapi from not uapi
>
> from the commit message:
>
> "
>
> This cleanly splits out the uverbs flags from the kernel flags to avoid
> confusion in the flags bitmap.
>
> "
>
> so it was not clear, at least to me, that some user flags are part of both
> the uapi and the kapi.
I tidied it a bit:
Split out flags from ib_device::device_cap_flags that are only used
internally to the kernel into kernel_cap_flags that is not part of the
uapi. This limits the device_cap_flags to being the same bitmap that will
be copied to userspace.
Thanks,
Jason
