On Thu, 2022-03-24 at 09:57 +1100, NeilBrown wrote: > On Tue, 22 Mar 2022, trondmy@xxxxxxxxxx wrote: > > From: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> > > > > We'd like to avoid GFP_NOWAIT whenever possible, because it has no > > fall- > > back reclaim strategy for dealing with a failure of the initial > > allocation. > > I'm not sure I entirely agree with that. GFP_NOWAIT will ensure > kswapd > runs on failure, so waiting briefly and retrying (which sunrpc does > on > -ENOMEM (at least ni call_refreshresult) is a valid fallback. > > However, I do like the new rpc_task_gfp_mask() and that fact that you > have used it quite widely. > > So: looks good to me. I haven't carefully reviewed each patch enough > to > say Reviewed-by, but I did see an easy problems. Thanks Neil! -- Trond Myklebust Linux NFS client maintainer, Hammerspace trond.myklebust@xxxxxxxxxxxxxxx
