On 24 Feb 2022, at 21:09, Trond Myklebust wrote: > On Thu, 2022-02-24 at 09:14 -0500, Benjamin Coddington wrote: >> There's a path through nfs4_lookup_revalidate that will now only produce >> this exit tracepoint. Does it need the _enter tracepoint added? > > You're thinking about the nfs_lookup_revalidate_delegated() path? The > _enter() tracepoint doesn't provide any useful information that isn't > already provided by the _exit(), AFAICS. No, the path through nfs4_do_lookup_revalidate(), reval_dentry: jump. But I agree there's not much value in the _enter() tracepoint. Maybe we can remove it, and _exit more like _done. I am thinking about hearing back from folks about mis-matched _enter() and _exit() results, but also realize this is nit-picking. Ben
