> On Feb 24, 2022, at 4:49 PM, NeilBrown <neilb@xxxxxxx> wrote:
>
> On Fri, 25 Feb 2022, Amir Goldstein wrote:
>> The nfsd file cache table can be pretty large and its allocation
>> may require as many as 80 contigious pages.
>>
>> Employ the same fix that was employed for similar issue that was
>> reported for the reply cache hash table allocation several years ago
>> by commit 8f97514b423a ("nfsd: more robust allocation failure handling
>> in nfsd_reply_cache_init").
>>
>> Fixes: 65294c1f2c5e ("nfsd: add a new struct file caching facility to nfsd")
>> Link: https://lore.kernel.org/linux-nfs/e3cdaeec85a6cfec980e87fc294327c0381c1778.camel@xxxxxxxxxx/
>> Suggested-by: Jeff Layton <jlayton@xxxxxxxxxx>
>> Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx>
>> ---
>>
>> Since v1:
>> - Use kvcalloc()
>> - Use kvfree()
>
> I think this is a good improvement, but it would be really nice to
> replace this bespoke hash table with an rhashtable. They we wouldn't
> need to worry about these trivial details.
I agree -- I didn't want to saddle Jeff or Amir with pulling
on that chain. But I'm willing to review patches that attempt
that kind of replacement (same for the DRC hash table).
--
Chuck Lever
