On Tue, Jan 25, 2022 at 07:30:05PM +0000, Chuck Lever III wrote: > > > > On Jan 25, 2022, at 2:17 PM, Dan Aloni <dan.aloni@xxxxxxxxxxxx> wrote: > > > > These pointers can be non-NULL and contain errors if initialization is > > aborted early. This is similar to how `__svc_rdma_free` takes care of > > it. > > IIUC the only place that can set these values to an > ERR_PTR is rpcrdma_ep_create() ? I think I'd rather > have rpcrdma_ep_create() set the fields to NULL in > the error cases. Actually that was my initialization draft but then I saw `__svc_rdma_free`. Will send over. > Good catch. I'm afraid to ask how you found this. Just some adapter entering error state in firmware. -- Dan Aloni
