On Wed, 2022-01-05 at 15:05 +0000, Ondrej Valousek wrote: > Hi all, > Sorry for confusion and maybe dumb questions: > - The aim is to transfer these attributes via RFC8276 (File System > Extended attributes in NFSv4)? No. > - AFAIK support for RFC8276 in NFS (only version 4.2) server is since > kernel 5.9, right? NFS client supports these as well? > - The patches below implements the feature in both, nfs client AND > server, right? > > I am bit confused as "btime" does not seem to be stored as extended > attribute in most local filesystems (checked ext4) but is in standard > inode structure. All these attributes are defined as regular attributes in rfc7530. All this code does is add the standard NFSv4 encoders/decoders for these attributes and adds the ioctl() to set/retrieve them all. There is no need to hack the NFS protocol to retrieve or set them using the xattr stuff. > Thanks, > Ondrej > > > -----Original Message----- > From: Trond Myklebust <trondmy@xxxxxxxxxxxxxxx> > Sent: pondělí 3. ledna 2022 21:52 > To: bfields@xxxxxxxxxxxx; trondmy@xxxxxxxxxx > Cc: linux-nfs@xxxxxxxxxxxxxxx; anna.schumaker@xxxxxxxxxx > Subject: Re: [PATCH 0/8] Support btime and other NFSv4 specific > attributes > > On Mon, 2022-01-03 at 15:51 -0500, J. Bruce Fields wrote: > > On Fri, Dec 17, 2021 at 03:48:46PM -0500, trondmy@xxxxxxxxxx wrote: > > > From: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> > > > > > > NFSv4 has support for a number of extra attributes that are of > > > interest to Samba when it is used to re-export a filesystem to > > > Windows clients. > > > Aside from the btime, which is of interest in statx(), Windows > > > clients have an interest in determining the status of the > > > 'hidden', > > > and 'system' > > > flags. > > > Backup programs want to read the 'archive' flags and the 'time > > > backup' > > > attribute. > > > Finally, the 'offline' flag can tell whether or not a file needs > > > to > > > be staged by an HSM system before it can be read or written to. > > > > > > The patch series also adds an ioctl() to allow userspace > > > retrieval > > > and setting of these attributes where appropriate. It also adds > > > an > > > ioctl() > > > to allow retrieval of the raw NFSv4 ACCESS information, to allow > > > more fine grained determination of the user's access rights to a > > > file or directory. All of this information is of use for Samba. > > > > Same question, what filesystem and server are you testing against? > > > > Same answer. > > > --b. > > > > > > > > Anne Marie Merritt (3): > > > nfs: Add timecreate to nfs inode > > > nfs: Add 'archive', 'hidden' and 'system' fields to nfs inode > > > nfs: Add 'time backup' to nfs inode > > > > > > Richard Sharpe (1): > > > NFS: Support statx_get and statx_set ioctls > > > > > > Trond Myklebust (4): > > > NFS: Expand the type of nfs_fattr->valid > > > NFS: Return the file btime in the statx results when > > > appropriate > > > NFSv4: Support the offline bit > > > NFSv4: Add an ioctl to allow retrieval of the NFS raw ACCESS > > > mask > > > > > > fs/nfs/dir.c | 71 ++--- > > > fs/nfs/getroot.c | 3 +- > > > fs/nfs/inode.c | 147 +++++++++- > > > fs/nfs/internal.h | 10 + > > > fs/nfs/nfs3proc.c | 1 + > > > fs/nfs/nfs4_fs.h | 31 +++ > > > fs/nfs/nfs4file.c | 550 > > > ++++++++++++++++++++++++++++++++++++++ > > > fs/nfs/nfs4proc.c | 175 +++++++++++- > > > fs/nfs/nfs4trace.h | 8 +- > > > fs/nfs/nfs4xdr.c | 240 +++++++++++++++-- > > > fs/nfs/nfstrace.c | 5 + > > > fs/nfs/nfstrace.h | 9 +- > > > fs/nfs/proc.c | 1 + > > > include/linux/nfs4.h | 1 + > > > include/linux/nfs_fs.h | 15 ++ > > > include/linux/nfs_fs_sb.h | 2 +- > > > include/linux/nfs_xdr.h | 80 ++++-- > > > include/uapi/linux/nfs.h | 101 +++++++ > > > 18 files changed, 1356 insertions(+), 94 deletions(-) > > > > > > -- > > > 2.33.1 > > -- > Trond Myklebust > Linux NFS client maintainer, Hammerspace > trond.myklebust@xxxxxxxxxxxxxxx > > > Legal Disclaimer: This e-mail communication (and any attachment/s) is > confidential and contains proprietary information, some or all of > which may be legally privileged. It is intended solely for the use of > the individual or entity to which it is addressed. Access to this > email by anyone else is unauthorized. If you are not the intended > recipient, any disclosure, copying, distribution or any action taken > or omitted to be taken in reliance on it, is prohibited and may be > unlawful. -- Trond Myklebust CTO, Hammerspace Inc 4984 El Camino Real, Suite 208 Los Altos, CA 94022 www.hammer.space
