Hi NeilBrown, Thank you for the patch! Yet something to improve: [auto build test ERROR on cifs/for-next] [also build test ERROR on axboe-block/for-next mszeredi-vfs/overlayfs-next rostedt-trace/for-next linus/master v5.16-rc5 next-20211216] [cannot apply to trondmy-nfs/linux-next hnaz-mm/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/NeilBrown/Repair-SWAP-over-NFS/20211217-075659 base: git://git.samba.org/sfrench/cifs-2.6.git for-next config: arm-randconfig-r005-20211216 (https://download.01.org/0day-ci/archive/20211217/202112171822.DW1WPE1G-lkp@xxxxxxxxx/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 9043c3d65b11b442226015acfbf8167684586cfa) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/0day-ci/linux/commit/6443c9d01129c1a1c19f3df4a594b01e3772e6bd git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review NeilBrown/Repair-SWAP-over-NFS/20211217-075659 git checkout 6443c9d01129c1a1c19f3df4a594b01e3772e6bd # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash fs/nfs/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): >> fs/nfs/file.c:512:8: error: implicit declaration of function 'add_swap_extent' [-Werror,-Wimplicit-function-declaration] ret = add_swap_extent(sis, 0, sis->max, 0); ^ 1 error generated. vim +/add_swap_extent +512 fs/nfs/file.c 486 487 static int nfs_swap_activate(struct swap_info_struct *sis, struct file *file, 488 sector_t *span) 489 { 490 unsigned long blocks; 491 long long isize; 492 int ret; 493 struct rpc_clnt *clnt = NFS_CLIENT(file->f_mapping->host); 494 struct inode *inode = file->f_mapping->host; 495 496 if (!file->f_mapping->a_ops->swap_rw) 497 /* Cannot support swap */ 498 return -EINVAL; 499 500 spin_lock(&inode->i_lock); 501 blocks = inode->i_blocks; 502 isize = inode->i_size; 503 spin_unlock(&inode->i_lock); 504 if (blocks*512 < isize) { 505 pr_warn("swap activate: swapfile has holes\n"); 506 return -EINVAL; 507 } 508 509 ret = rpc_clnt_swap_activate(clnt); 510 if (ret) 511 return ret; > 512 ret = add_swap_extent(sis, 0, sis->max, 0); 513 if (ret < 0) { 514 rpc_clnt_swap_deactivate(clnt); 515 return ret; 516 } 517 *span = sis->pages; 518 sis->flags |= SWP_FS_OPS; 519 return ret; 520 } 521 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
