The sparse tool complains as follows: fs/nfsd/nfssvc.c:437:1: warning: symbol 'nfsd_notifier_lock' was not declared. Should it be static? This symbol is not used outside of nfssvc.c, so marks it static. Fixes: 6ac25fbcbde9 ("NFSD: simplify locking for network notifier.") Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx> --- fs/nfsd/nfssvc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c index 070525fbc1ad..14c1ef6f8cc7 100644 --- a/fs/nfsd/nfssvc.c +++ b/fs/nfsd/nfssvc.c @@ -434,7 +434,7 @@ static void nfsd_shutdown_net(struct net *net) nfsd_shutdown_generic(); } -DEFINE_SPINLOCK(nfsd_notifier_lock); +static DEFINE_SPINLOCK(nfsd_notifier_lock); static int nfsd_inetaddr_event(struct notifier_block *this, unsigned long event, void *ptr) {