Hi Bruce-
Here are some random scribblings I did over the past week to start
cleaning up dprintk call sites in the kernel RPC server
implementation.
As I stated before, it's my opinion (and not at all a NACK) that
because we've never left single dprintk call sites in place for
deprecated DEBUG failicities, we don't need to do it here. My
preference is simply to deal with this in rpcdebug if we think there
is a strong need. I'd rather see a warning note come out of the
administrative interface immediately upon attempted use, instead of
to see nothing and then see a kernel warning at some point much
later (or not at all if the only remaining call site for that
facility is never encountered).
I know others have different opinions about this. We had only a few
minutes to discuss it during the BAT, and the issue might still be
without consensus. There's still opportunity to work it out on list.
---
Chuck Lever (14):
SUNRPC: Update the show_svc_xprt_flags() macro
SUNRPC: Remove dprintk call sites from svcauth_unix.c
SUNRPC: Remove dprintk call site from svc_authenticate()
SUNRPC: Clean up svc_destroy()
SUNRPC: Remove dprintk call site from __svc_create()
SUNRPC: Remove dprintk call site from bc_svc_process()
SUNRPC: Remove redundant dprintk call sites from svc_process_common()
SUNRPC: Report short RPC messages via a tracepoint
SUNRPC: Report RPC messages with unknown programs via a tracepoint
SUNRPC: Report RPC messages with unknown versions via a tracepoint
SUNRPC: Report RPC messages with unknown procedures via a tracepoint
SUNRPC: Report RPC messages that can't be decoded via a tracepoint
SUNRPC: Fix kdoc comment for svc_unregister()
SUNRPC: Yank some low-value dprintk call sites
include/trace/events/sunrpc.h | 156 ++++++++++++++++++++++++++++++----
net/sunrpc/svc.c | 78 ++++-------------
net/sunrpc/svc_xprt.c | 19 -----
net/sunrpc/svcauth.c | 4 -
net/sunrpc/svcauth_unix.c | 4 -
5 files changed, 155 insertions(+), 106 deletions(-)
--
Chuck Lever
