> On Oct 13, 2021, at 10:31 AM, J. Bruce Fields <bfields@xxxxxxxxxxxx> wrote: > > On Tue, Oct 12, 2021 at 11:57:15AM -0400, Chuck Lever wrote: >> As we discussed many moons ago, here are clean-up patches that >> modernize the .pc_decode callback's synopsis, based on the >> recent XDR overhaul work. > > Looks sensible to me. > > Applying pending some testing. Thanks, Bruce. I have similar patches for .pc_encode. Do you want to test those at the same time? > --b. > >> >> --- >> >> Chuck Lever (2): >> SUNRPC: Replace the "__be32 *p" parameter to .pc_decode >> SUNRPC: Change return value type of .pc_decode >> >> >> fs/lockd/svc.c | 3 +- >> fs/lockd/xdr.c | 123 +++++++++++++--------------- >> fs/lockd/xdr4.c | 124 ++++++++++++++-------------- >> fs/nfsd/nfs2acl.c | 36 ++++---- >> fs/nfsd/nfs3acl.c | 26 +++--- >> fs/nfsd/nfs3xdr.c | 163 +++++++++++++++++-------------------- >> fs/nfsd/nfs4xdr.c | 28 +++---- >> fs/nfsd/nfsd.h | 3 +- >> fs/nfsd/nfssvc.c | 11 ++- >> fs/nfsd/nfsxdr.c | 92 ++++++++++----------- >> fs/nfsd/xdr.h | 21 ++--- >> fs/nfsd/xdr3.h | 31 +++---- >> fs/nfsd/xdr4.h | 2 +- >> include/linux/lockd/xdr.h | 19 +++-- >> include/linux/lockd/xdr4.h | 19 ++--- >> include/linux/sunrpc/svc.h | 3 +- >> 16 files changed, 334 insertions(+), 370 deletions(-) >> >> -- >> Chuck Lever -- Chuck Lever