Hi- So based on Trond's earlier comment, this is what I've come up with. These apply on top of the three patches Trond has already accepted. I kind of wanted to do "task:%04x@%04x", but the "-1" still displays as "ffffffff", so I left it as "task:%08x@%08x" to keep the fields lined up in aligned columns. Any different ideas are welcome. There are a couple of other fix-ups I found while working on this update, and I've also included an optional patch to add the nfs_readpage(s) tracepoints I found useful while tracking down recent fsx failures. --- Chuck Lever (5): SUNRPC: Tracepoints should display tk_pid and cl_clid as a fixed-size field SUNRPC: Avoid NULL pointer dereferences in tracepoints SUNRPC: Use BIT() macro in rpc_show_xprt_state() SUNRPC: Don't dereference xprt->snd_task if it's a cookie NFS: Replace dprintk callsites in nfs_readpage(s) fs/nfs/nfs4trace.h | 17 ++- fs/nfs/nfstrace.h | 79 ++++++++++++- fs/nfs/read.c | 8 +- include/trace/events/rpcgss.h | 36 +++--- include/trace/events/rpcrdma.h | 104 +++++++---------- include/trace/events/sunrpc.h | 182 +++++++++++++---------------- include/trace/events/sunrpc_base.h | 42 +++++++ 7 files changed, 265 insertions(+), 203 deletions(-) create mode 100644 include/trace/events/sunrpc_base.h -- Chuck Lever