David Wysochanski <dwysocha@xxxxxxxxxx> wrote: > The added "if (ret < 0) ..." renders the bulk of the switch statement with > non-zero cases moot. I have a patch or two on top of it that cleans this > up, and replaces the dfprintks with tracepoints. If you want I can try to > merge at least bits of it into a v3 of this patch, and leave the dfprintk > conversion to tracepoints for another patch. If you can give me the clean up bits, I can fold them in. I think it's probably worth keeping the dfprintk conversion separate. David